Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iox #1196 fix serialization warnings #1459

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Iox #1196 fix serialization warnings #1459

merged 1 commit into from
Jul 7, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jul 7, 2022 •
edited
Loading

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the technical debt unclean code and design flaws label Jul 7, 2022
@elBoberido elBoberido self-assigned this Jul 7, 2022
@elBoberido elBoberido changed the base branch from iox-#1196-fix-clang-tidy-warnings-integration-branch to master July 7, 2022 03:08
elfenpiff
elfenpiff previously approved these changes Jul 7, 2022
View reviewed changes
@elBoberido elBoberido force-pushed the iox-#1196-fix-serialization-warnings branch 2 times, most recently from e69df30 to a0f2738 Compare July 7, 2022 04:55
@elBoberido elBoberido force-pushed the iox-#1196-fix-serialization-warnings branch from a0f2738 to 2c3dcd6 Compare July 7, 2022 05:06
@elBoberido elBoberido requested a review from elfenpiff July 7, 2022 05:07
@codecov
Copy link

codecov bot commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #1459 (2c3dcd6) into master (4d7102a) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
- Coverage   78.78%   78.76%   -0.02%     
==========================================
  Files         377      377              
  Lines       14477    14474       -3     
  Branches     2011     2009       -2     
==========================================
- Hits        11406    11401       -5     
- Misses       2434     2435       +1     
- Partials      637      638       +1
Flag Coverage Δ
unittests 78.43% <87.50%> (-0.02%) ⬇️
unittests_timing 14.90% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...clude/iceoryx_hoofs/internal/cxx/serialization.inl 88.23% <87.50%> (+3.05%) ⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp 80.00% <0.00%> (-11.43%) ⬇️

@elBoberido elBoberido added the refactoring Refactor code without adding features label Jul 7, 2022
@elBoberido elBoberido merged commit fd6b5e4 into eclipse-iceoryx:master Jul 7, 2022
@elBoberido elBoberido deleted the iox-#1196-fix-serialization-warnings branch July 7, 2022 07:54
@elBoberido elBoberido linked an issue Jul 7, 2022 that may be closed by this pull request
Enable clang-tidy checks and fix warnings in code #1196
Closed
85 tasks
@mossmaurice mossmaurice added clang-tidy Warning of a clang-tidy rule and removed refactoring Refactor code without adding features technical debt unclean code and design flaws labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler FerdinandSpitzschnueffler approved these changes

@elfenpiff elfenpiff elfenpiff approved these changes

Assignees

@elBoberido elBoberido

Labels
clang-tidy Warning of a clang-tidy rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable clang-tidy checks and fix warnings in code
4 participants
@elBoberido @elfenpiff @FerdinandSpitzschnueffler @mossmaurice